Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wasm-opt regression #187

Merged
merged 6 commits into from
Feb 22, 2021
Merged

Fix wasm-opt regression #187

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a5b1cab
Use `--zero-filled-memory` for `wasm-opt`
cmichi Feb 19, 2021
facb7e9
Assert that compiled contract template is below 3k
cmichi Feb 19, 2021
b57112a
Apply cargo fmt
cmichi Feb 19, 2021
f31950d
Remove superfluous comment
cmichi Feb 19, 2021
f888044
Improve error message on `wasm-opt` error
cmichi Feb 19, 2021
4a2a306
Specify minimum binaryen version
cmichi Feb 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply cargo fmt
  • Loading branch information
@cmichi
cmichi committed Feb 19, 2021
commit b57112a6fd098327a29ba57f4fe6c5b3a88d2458
2 changes: 0 additions & 2 deletions src/cmd/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,12 +352,10 @@ fn do_optimization(
.arg(format!("-O{}", optimization_level))
.arg("-o")
.arg(dest_optimized)

// the memory in our module is imported, `wasm-opt` needs to be told that
// the memory is initialized to zeros, otherwise it won't run the
// memory-packing pre-pass.
.arg("--zero-filled-memory")
cmichi marked this conversation as resolved.
Show resolved Hide resolved

.output()?;

if !output.status.success() {
Expand Down