Nightly test new CI image #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
reviewed
Dec 2, 2020
| @@ -52,7 +48,6 @@ workflow: | |||
| - if: $CI_PIPELINE_SOURCE == "schedule" | |||
| - if: $CI_COMMIT_REF_NAME == "master" | |||
| - if: $CI_COMMIT_REF_NAME == "tags" | |||
| - if: $CI_COMMIT_BRANCH | |||
There was a problem hiding this comment.
What does it imply that this variable is removed?
There was a problem hiding this comment.
nothing really, it's supposed to launch CI pipelines on every branch which is not desirable, we run the usual pipelines only on PR branches, it's covered by the next line. Besides, branches other than PR ones are not getting mirrored to GitLab.
ascjones
reviewed
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put the image name into a var so it can be changed by an upstream pipeline trigger.
Companion PR: paritytech/scripts#238