Compare Environment types against the node (#1377)

* check env types * add changelog * resolve merge conflict * refactor API * attempt to add tests * test type resolution * check for invalid composite types * test the env match between contract and node * remove comment * test mismatch * remove json file * move module to extrinsics * update the metadata to only refer to contracts * adjust segment search * use anyhow error * adjust segment comparison * print warning if Env is not present in node metadata * prettify code a bit * use let-else and proper warning * add proper verbosity flag * elborate warning msg * vanila eprintln * saturating sub for slice bound
use-ink · Oct 25, 2023 · 1a1024d · 1a1024d
1 parent dfdc768
commit 1a1024d
Show file tree

Hide file tree

Showing 11 changed files with 459 additions and 34 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ## [Unreleased]
 
 ### Added
+- Compare `Environment` types against the node - [#1377](https://github.com/paritytech/cargo-contract/pull/1377)
 - Adds workflow for publishing docker images for the verifiable builds - [#1267](https://github.com/paritytech/cargo-contract/pull/1267)
 - Detect `INK_STATIC_BUFFER_SIZE` env var - [#1310](https://github.com/paritytech/cargo-contract/pull/1310)
 - Add `verify` command - [#1306](https://github.com/paritytech/cargo-contract/pull/1306)

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/crates/extrinsics/Cargo.toml b/crates/extrinsics/Cargo.toml
@@ -38,6 +38,7 @@ scale-info = "2.10.0"
 subxt = "0.32.1"
 subxt-signer = { version = "0.32.1", features = ["subxt", "sr25519"] }
 hex = "0.4.3"
+ink_metadata = "5.0.0-alpha"
 
 [dev-dependencies]
 assert_cmd = "2.0.12"

diff --git a/crates/extrinsics/src/call.rs b/crates/extrinsics/src/call.rs
@@ -31,7 +31,10 @@ use super::{
     Missing,
     TokenMetadata,
 };
-use crate::extrinsic_opts::ExtrinsicOpts;
+use crate::{
+    check_env_types,
+    extrinsic_opts::ExtrinsicOpts,
+};
 
 use anyhow::{
     anyhow,
@@ -186,6 +189,7 @@ impl CallCommandBuilder<state::Message, state::ExtrinsicOptions> {
         let rpc = RpcClient::from_url(&url).await?;
         let client = OnlineClient::from_rpc_client(rpc.clone()).await?;
         let rpc = LegacyRpcMethods::new(rpc);
+        check_env_types(&client, &transcoder)?;
 
         let token_metadata = TokenMetadata::query(&rpc).await?;