-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka topics management #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael7371
requested changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just one comment.
Michael7371
approved these changes
Sep 3, 2024
3 tasks
John-Wiens
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
kafka-setup
service to use the jikkou resource-as-code framework to create Kafka topics.The
kafka-setup
service can now be configured with the environment variables described in the updated README to create groups of topics for the ODE applications:jpo-ode
,jpo-geojsonconverter
,jpo-conflictmonitor
, andjpo-deduplicator
.New/updated files in the
/kafka
folder:kafka-topics-values.yaml
- Configuration file containing topics for all applicationskafka-topics-template.jinja
- A template to create resource definitions for the topics.application.conf
,jikkouconfig
- Jikkou configuration fileskafka_init.sh
- Initialization script that runs the Jikkou CLI to validate the resource definitions and create topicsDockerfile.jikkou
- Runs the init script in a container.This PR also adds a health check to the
kafka
service indocker-compose-kafka.yml
, and adds dependencies to the other containers in that compose so that they wait for Kafka to fully start up before running.Tested by running Docker Compose with the
kafka_full
profile, and observing the topics created in the Kafka UI.Future Development
Worth looking into for future updates: