Skip to content

Kernel attach and bulk fixes #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions src/main/java/org/usb4java/javax/AbstractDevice.java
Original file line number Diff line number Diff line change
Expand Up @@ -74,16 +74,16 @@ abstract class AbstractDevice implements UsbDevice
/** The numbers of the currently claimed interface. */
private Set<Byte> claimedInterfaceNumbers = new HashSet<Byte>();

/** The numbers of the currently kernel claimed interface. */
private Set<Byte> claimedKernelInterfaceNumbers = new HashSet<Byte>();

/** The port this device is connected to. */
private UsbPort port;

/** The IRP queue. */
private final ControlIrpQueue queue = new ControlIrpQueue(this,
this.listeners);

/** If kernel driver was detached when interface was claimed. */
private boolean detachedKernelDriver;

/**
* Constructs a new device.
*
Expand Down Expand Up @@ -248,6 +248,14 @@ public final void close()
}
}

public final void reset()
{
if (this.handle != null)
{
LibUsb.resetDevice(this.handle);
}
}

@Override
public final UsbPort getParentUsbPort()
{
Expand Down Expand Up @@ -400,6 +408,12 @@ final void setActiveUsbConfigurationNumber(final byte number)
final void claimInterface(final byte number, final boolean force)
throws UsbException
{
if(this.claimedInterfaceNumbers.isEmpty()) {
// This prevent a libus bug where async read could lock
// forever after a full released interfaces
reset();
}

if (this.claimedInterfaceNumbers.contains(number))
throw new UsbClaimException("An interface is already claimed");

Expand All @@ -420,7 +434,7 @@ final void claimInterface(final byte number, final boolean force)
throw ExceptionUtils.createPlatformException(
"Unable to detach kernel driver", result);
}
this.detachedKernelDriver = true;
claimedKernelInterfaceNumbers.add(number);
}
}

Expand Down Expand Up @@ -456,17 +470,24 @@ final void releaseInterface(final byte number) throws UsbException
"Unable to release interface", result);
}

if (this.detachedKernelDriver)
if (this.claimedKernelInterfaceNumbers.contains(number))
{
result = LibUsb.attachKernelDriver(handle, number & 0xff);
if (result < 0)
{
throw ExceptionUtils.createPlatformException(
"Unable to re-attach kernel driver", result);
}
this.claimedKernelInterfaceNumbers.remove(number);
}

this.claimedInterfaceNumbers.remove(number);

if(this.claimedInterfaceNumbers.isEmpty()) {
// This prevent a libus bug where async read could lock
// forever after a full released interfaces
reset();
}
}

/**
Expand Down
11 changes: 11 additions & 0 deletions src/main/java/org/usb4java/javax/IrpQueue.java
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,17 @@ private int write(final byte[] data, final int offset, final int len)
// Short packet detected, aborting
if (result < size) break;
}

// Handle bulk out transfert needing zlp to detect end of packet
if ((this.pipe.getUsbEndpoint().getDirection() == UsbConst.ENDPOINT_DIRECTION_OUT)) {
if (type == LibUsb.TRANSFER_TYPE_BULK) {
if ((len > 0) && (len % descriptor.wMaxPacketSize() == 0)) {
transfer(handle, descriptor, type, ByteBuffer.allocateDirect(0));
}
}
}


return written;
}

Expand Down