-
Notifications
You must be signed in to change notification settings - Fork 2
some source code organization and fixes #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
memre
wants to merge
18
commits into
usb-k:master
Choose a base branch
from
memre:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix 64bit problem - install files to /usr, not /usr/local
Author
|
Oh, I just saw that my old changes already merged :) Most of the "changes item" can be ignored, since there is not much fixes but the cosmetics :) |
Writing functions inside libusbk.h header causes multiple definitions if two or more module includes libusbk. When a module includes libusbk.h, functions includes in the module too, and if another module includes libusbk.h then other all functions will be placed that module again and linker causes multiple definition functions error. headers should contain just prototypes of the functions.
- some functions should be inline - remove unneccessary library functions
- enumerated types reorganazed both their typedefs and types. - elements of the usbk struct renamed - elements of the usbk structure documented.
- libudef clears all contexts as default, so manually unrefs causes segfaults.
- add libusbk++ skeleton - add config.h to libusbk - some refactors to libusbk for c++ bindings
By the time developing libusbk++ and usbk_cli, if there is a header
installed in the system, sometimes that header might be included
instead of most current version of libusbk.h{,pp}.
This will be fixed soon, but we wrote relative path as temporary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some source code organization and fixes.
Added features:
I can begin qusbk project to my x86_64 Pardus 2011 machine.