Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add log_level for FPM logs #169

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

agustingomes
Copy link
Contributor

@agustingomes agustingomes commented Feb 25, 2021

Usabilla PHP Docker Template

Reviewers: @usabilla/oss-docker

Type

Please specify the type of changes being proposed:

Q A
Documentation? yes
Dockerfile change? no
Build feature? yes
Apply CVE Patch? no
Remove CVE Patch? no

Changelog

This change aims to add control over the log level outputted by FPM itself. I've noticed we have a high volume of logs with notice level that will look like this:

"[22-Feb-2021 09:17:02] NOTICE: [pool www] child 10444 started"
"[22-Feb-2021 09:17:03] NOTICE: [pool www] child 10320 exited with code 0 after 17.567216 seconds from start"
"[22-Feb-2021 09:17:03] NOTICE: [pool www] child 10445 started"
"[22-Feb-2021 09:17:09] NOTICE: [pool www] child 10359 exited with code 0 after 16.352465 seconds from start"
"[22-Feb-2021 09:17:09] NOTICE: [pool www] child 10514 started"
"[22-Feb-2021 09:17:11] NOTICE: [pool www] child 10360 exited with code 0 after 17.717351 seconds from start"
"[22-Feb-2021 09:17:11] NOTICE: [pool www] child 10523 started"
"[22-Feb-2021 09:17:11] NOTICE: [pool www] child 10400 exited with code 0 after 17.065780 seconds from start"

The new variable added will allow us to control the minimum level we want our FPM processes to log. note that this logging is different than the one from the application itself.

Copy link
Member

@rdohms rdohms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please document this in the README?

Also internally, not sure we want to lower our threshold, as these logs have been useful. Right @WyriHaximus ?

@WyriHaximus
Copy link
Member

Can you please document this in the README?

@agustingomes And set the current defaults in the Dockerfile's?

Also internally, not sure we want to lower our threshold, as these logs have been useful. Right @WyriHaximus ?

@rdohms At the moment we need these logs to detect certain issues. So yes they are very useful.

@WyriHaximus WyriHaximus removed their request for review March 23, 2021 08:01
@frankkoornstra frankkoornstra removed their request for review July 12, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants