Migrate to GitHub Actions

[WyriHaximus]

Reviewers: @usabilla/oss-docker

Please specify the type of changes being proposed:

Q	A
Documentation?	no
Dockerfile change?	no
Build feature?	yes
Apply CVE Patch?	no
Remove CVE Patch?	no

Changes

This PR replaces the current Circle CI pipeline with a GitHub Action workflow. This is a table with all the changes to each step changed:

Circle CI	GitHub Actions	Changes
lint-shell	lint-shell	N/A
lint	lint-docker	N/A
build-prometheus-exporter-file	build-prometheus-exporter-file	N/A
build-http	build-http	The builds of ngnix images now run in parallel
build-fpm	build-php	The builds of PHP FPM images now run in parallel
build-cli	build-php	The builds of PHP CLI images now run in parallel
scan-vulnerability	scan-vulnerability-(php/http/prometheus-exporter-file)	Now the steps to scan images' vulnerabilities are split
test-cli	test-php	Now test-cli and test-fpm run in the same step, but in parallel
test-fpm	test-php	Now test-cli and test-fpm run in the same step, but in parallel
test-http	test-http	Now http-test and test-http-e2e run in the same step, across all versions of Alpine, Ngnix and PHP
test-http-e2e	test-http	Now make http-test and make test-http-e2e run in the same step, across all versions of Alpine, Ngnix and PHP
test-prometheus-exporter-file-e2e	test-prometheus-exporter-file	N/A
push-approval	N/A	This is done automatically by GitHub Actions
push-cli	push-php	Now push-cli and push-fpm run in the same step, but in parallel
push-fpm	push-php	Now push-cli and push-fpm run in the same step, but in parallel
push-http	push-http	N/A
push-prometheus-exporter-file	push-prometheus-exporter-file	N/A

Benchmarks

CircleCI takes usually 30min or more to run all the steps, excluding the pushing of the images. Examples:

• https://app.circleci.com/pipelines/github/usabilla/php-docker-template/426/workflows/f032e803-05f2-4b8c-a6ff-9a7ae09295e1
• https://app.circleci.com/pipelines/github/usabilla/php-docker-template/342/workflows/f631821e-b014-4f86-a286-77bcdb895c09

GitHub Actions usually take 15min or less to run all the steps, including the new ones, and excluding the pushing of the images. Some examples:

• https://github.com/usabilla/php-docker-template/actions/runs/329301145
• https://github.com/usabilla/php-docker-template/actions/runs/324293937

TODOs

• Drop Circle CI requirements from GitHub's master branch protection

[renatomefi]

You can also use yaml native templating, so you could avoid some of the repetitions like this one

[carusogabriel]

That's huge 🚀

[cvmiert]

🚢

[bendavies]

what is this for?

[WyriHaximus]

We have branch protection on the main branch, and instead of having to check/uncheck 60 required checks when we add/remove new PHP versions we only make this job required as it requires the previous jobs to pass before it even runs. This way we don't have to update the required checks when a job's name changes or a new version comes into play, or when we consolidate all the build jobs into one.

[bendavies]

ah, i suggest using https://github.com/probot/settings for managing that stuff, not manually clicking in the UI. HTH!

[WyriHaximus]

That could work, but it would mean updating the settings file and the naming/versions in two different PR as AFAIK the settings need to be applied/merged before they are effective on the PR. (I do love that suggestions, using it for my personal repo's to managed settings 👍 .)

[bendavies]

that is true - but we do the update in one PR and just have an admin merge :)

[WyriHaximus]

That is also a possibility. But what I would like even more is that they let us select the underlying job name instead of the fancy user friendly name, that way you only have to select a handful instead of nearly a 100 🤐 . brb doing a feature suggestion to GitHub for that