[FIX] hr_employee_service_contract: remove duplicate view

hr_employee_service_contract/__manifest__.py

@@ -26,7 +26,4 @@
             'dateutil',
         ],
     },
-    'data': [
-        'views/hr_employee.xml',
-    ],
 }

hr_employee_service_contract/models/hr_employee.py

@@ -35,30 +35,42 @@ class HrEmployee(models.Model):
     def _compute_first_contract_id(self):
         Contract = self.env['hr.contract']
         for employee in self:
-            employee.first_contract_id = Contract.search([
-                ('employee_id', '=', employee.id),
-                ('state', 'not in', self._service_contract_states()),
-            ], order='date_start asc', limit=1)
+            employee.first_contract_id = Contract.search(
+                employee._get_contract_filter(),
+                order='date_start asc',
+                limit=1
+            )
 
     @api.multi
     @api.depends('contract_ids')
     def _compute_last_contract_id(self):
         Contract = self.env['hr.contract']
         for employee in self:
-                employee.last_contract_id = Contract.search([
-                    ('employee_id', '=', employee.id),
-                    ('state', 'not in', self._service_contract_states()),
-                ], order='date_end desc', limit=1)
+            employee.last_contract_id = Contract.search(
+                employee._get_contract_filter(),
+                order='date_end desc',
+                limit=1
+            )
 
     @api.multi
     @api.onchange('service_hire_date')
     def _onchange_service_hire_date(self):  # pragma: no cover
         # Do nothing
         pass
 
+    @api.multi
+    def _get_contract_filter(self):
+        self.ensure_one()
+
+        return [
+            ('employee_id', '=', self.id),
+            ('state', 'in', self._get_service_contract_states()),
+        ]
+
     @api.model
-    def _service_contract_states(self):
+    def _get_service_contract_states(self):
         return [
-            'draft',
-            'cancel',
+            'open',
+            'pending',
+            'close',
         ]