Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Generating performance report for 16.0.0 #84

Closed
raulcd opened this issue Apr 19, 2024 · 1 comment · Fixed by #85
Closed

Error Generating performance report for 16.0.0 #84

raulcd opened this issue Apr 19, 2024 · 1 comment · Fixed by #85

Comments

@raulcd
Copy link
Collaborator

raulcd commented Apr 19, 2024

I job failed when generating the Performance Report comparison between 16.0.0 and 15.0.2 RC3:

Quitting from lines 351-369 [compute-process-micro-bm-data] (performance-release-report.qmd)
Error in `rename_with()` at dplyr/R/mutate.R:146:2:
! Names must be unique.
✖ These names are duplicated:
  * "unit" at locations 3 and 79.
Backtrace:
  1. ... %>% ...
 26. dplyr:::rename_with.data.frame(., ~gsub("baseline.tags.", "", .))
       at dplyr/R/rename.R:84:2
Warning messages:
1: Unknown or uninitialised column: `baseline`. 
2: Unknown or uninitialised column: `contender`. 
Execution halted
ERROR: Error
    at renderFiles (file:///opt/quarto/bin/quarto.js:77074:29)
    at eventLoopTick (ext:core/01_core.js:183:11)
    at async render (file:///opt/quarto/bin/quarto.js:81807:21)
    at async Command.fn (file:///opt/quarto/bin/quarto.js:81954:32)
    at async Command.execute (file:///opt/quarto/bin/quarto.js:8104:13)
    at async quarto (file:///opt/quarto/bin/quarto.js:114968:5)
    at async file:///opt/quarto/bin/quarto.js:114986:9

This is the job failure: https://github.com/ursacomputing/crossbow/actions/runs/8750575039/job/24014381152

@raulcd
Copy link
Collaborator Author

raulcd commented Apr 19, 2024

@boshek @assignUser

raulcd pushed a commit that referenced this issue Apr 20, 2024
Closes #84 

With:

```
BASELINE_GIT_COMMIT=e03105efc38edca4ca429bf967a17b4d0fbebe40
CONTENDER_GIT_COMMIT=6a28035c2b49b432dc63f5ee7524d76b4ed2d762
```

This will fix report rendering. However, it is worth mentioning that
this still will exclude the C++ benchmarks as those failed for the
`6a28035c2b49b432dc63f5ee7524d76b4ed2d762` run.

cc @raulcd and @assignUser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant