[1.26] Add server_hostname to SSL_KEYWORDS

urllib3 · Jan 20, 2022 · f1d40fd · f1d40fd
1 parent b1f60e4
commit f1d40fd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/urllib3/poolmanager.py b/src/urllib3/poolmanager.py
@@ -34,6 +34,7 @@
     "ca_cert_dir",
     "ssl_context",
     "key_password",
+    "server_hostname",
 )
 
 # All known keyword arguments that could be provided to the pool manager, its

diff --git a/test/with_dummyserver/test_poolmanager.py b/test/with_dummyserver/test_poolmanager.py
@@ -346,6 +346,11 @@ def test_http_with_ssl_keywords(self):
             r = http.request("GET", "http://%s:%s/" % (self.host, self.port))
             assert r.status == 200
 
+    def test_http_with_server_hostname(self):
+        with PoolManager(server_hostname="example.com") as http:
+            r = http.request("GET", "http://%s:%s/" % (self.host, self.port))
+            assert r.status == 200
+
     def test_http_with_ca_cert_dir(self):
         with PoolManager(ca_certs="REQUIRED", ca_cert_dir="/nosuchdir") as http:
             r = http.request("GET", "http://%s:%s/" % (self.host, self.port))