Skip to content

Conversation

@urjitbhatia
Copy link
Owner

@urjitbhatia urjitbhatia commented Jun 6, 2023

Extend will honour values right to left, ie, it will overwrite values provided on the right. The current implementation ignores the reqopts.timeout in preference of the timeout set on the service itself which means users of this interface cannot set a timeout properly per request.

Example:

> extend({foo:1}, {bar:2}, {foo:3})
{ foo: 3, bar: 2 }

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes googleapis#772 🦕

Extend will honour values right to left, ie, it will overwrite values provided on the right. The current implementation ignores the `reqopts.timeout` in preference of the timeout set on the service itself which means users of this interface cannot set a timeout properly per request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Service request timeout is overwritten at call time

2 participants