Skip to content

Conversation

@XinyuLiu5566
Copy link

When I run pytest --flake-finder on this test, it passes/fails periodically, so it might be a flaky test. After the code modification by adding a try-except block, it passes all the time.

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #139 (8c8728b) into develop (f110260) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #139   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          582       582           
=========================================
  Hits           582       582           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f110260...8c8728b. Read the comment docs.

Copy link
Owner

@uriyyo uriyyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I think this test isn't flaky. I rerun tests several times and this test didn't fail.

IMHO it's bad practice to suppress exceptions, especially in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants