- 
                Notifications
    
You must be signed in to change notification settings  - Fork 61
 
Лебедев Никита #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Лебедев Никита #33
Conversation
| 
           🍏 Пройден линтинг и базовые тесты  | 
    
| display: inline-block; | ||
| vertical-align: top; | ||
| margin-right: 12px; | ||
| margin-bottom: 10px; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Можно записать кратко, но не обязательно
        
          
                index.css
              
                Outdated
          
        
      | vertical-align: top; | ||
| margin-right: 12px; | ||
| margin-bottom: 10px; | ||
| 
               | 
          
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А вот от пустых строчек лучше избавиться
| .card:hover | ||
| { | ||
| box-shadow: 1px 4px 8px 0 rgba(0,0,0,.3), 0 6px 20px 0 rgba(0,0,0,.29); | ||
| transition: all 400ms ease-out; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
        
          
                index.css
              
                Outdated
          
        
      | { | ||
| font-size: 1.5em; | ||
| display: block; | ||
| 
               | 
          
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:(
        
          
                index.css
              
                Outdated
          
        
      | { | ||
| color: #a52a2a; | ||
| font-size: 1.5em; | ||
| margin-right: 4px; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Магические 4 пикселя :)
| .photo | ||
| { | ||
| display: block; | ||
| filter: grayscale(.4) brightness(.8); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Очень здорово 👍
        
          
                index.css
              
                Outdated
          
        
      | 
               | 
          ||
| .photo | ||
| { | ||
| display: block; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Зачем?
        
          
                index.css
              
                Outdated
          
        
      | { | ||
| display: block; | ||
| width: 100%; | ||
| 
               | 
          
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:(
        
          
                index.css
              
                Outdated
          
        
      | margin: 10px 0; | ||
| width: 250px; | ||
| text-align: center; | ||
| 
               | 
          
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:(
        
          
                index.css
              
                Outdated
          
        
      | -moz-user-select: none; | ||
| -ms-user-select: none; | ||
| user-select: none; | ||
| 
               | 
          
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:(
| 
          
 Почитай про алгоритм выравнивания по ширине Вот тут есть крутой хак и хорошее описание  | 
    
| 
           Здорово, что сделал анимации по наведению.  | 
    
| 
           🚀  | 
    
| 
           🍏 Пройден линтинг и базовые тесты  | 
    
| 
           🍏 Пройден линтинг и базовые тесты  | 
    
| 
           Общепринятый паттерн что картинка так же является ссылкой и по наведению на картинку ссылка подсвечивается (обратное тоже верно) сделаешь?  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍅
        
          
                index.html
              
                Outdated
          
        
      | <div class="description">Ленивый домашний кот, 4 месяца, приучен к лотку. | ||
| Питается сухим кормом.</div> | ||
| </div> | ||
| <!-- | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В чём сакральных смысл этих пустых комментариев?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Они нужны, чтобы не было промежутков между inline-block элементами
(они просто сломались при форматировании)
        
          
                index.css
              
                Outdated
          
        
      | .link | ||
| { | ||
| font-size: 1.5em; | ||
| display: block; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Делать ссылки блочными плохо, потому что появляются пустые места, которые при этом являются ссылками
| 
           🍏 Пройден линтинг и базовые тесты  | 
    
| 
           🍏 Пройден линтинг и базовые тесты  | 
    
| 
           Из фразы 
 не реализована часть 
 🍅  | 
    
| 
           🍏 Пройден линтинг и базовые тесты  | 
    
| 
           🍏  | 
    
| 
           Из фразы 
 Не реализована часть «обратное тоже верно»  | 
    
| 
           🍅  | 
    

Посмотреть решение