Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide version info if user has not defined version [v2] #955

Merged
merged 4 commits into from
Nov 28, 2019

Conversation

asahasrabuddhe
Copy link
Member

Fixes #248 and #524

Changes

  • Do not set default version
  • HideVersion is now true if the user does not define flag

@asahasrabuddhe asahasrabuddhe requested a review from a team as a code owner November 28, 2019 06:52
@codecov
Copy link

codecov bot commented Nov 28, 2019

Codecov Report

Merging #955 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #955      +/-   ##
==========================================
- Coverage   73.37%   73.36%   -0.02%     
==========================================
  Files          32       32              
  Lines        2441     2440       -1     
==========================================
- Hits         1791     1790       -1     
  Misses        540      540              
  Partials      110      110
Impacted Files Coverage Δ
app.go 76.98% <100%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d64fe0...286ffd2. Read the comment docs.

@asahasrabuddhe asahasrabuddhe merged commit a7cc974 into master Nov 28, 2019
@coilysiren coilysiren mentioned this pull request Dec 24, 2019
@coilysiren coilysiren deleted the inconsistent-version-behaviour-v2 branch December 25, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If the Version string is empty, the version section should not appear in usage output
3 participants