Skip to content

merge altsrc with main package #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

merge altsrc with main package #1058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ffb4663
Integrate altsrc in main package
asahasrabuddhe Oct 9, 2019
6f56841
Fix test cases
asahasrabuddhe Oct 9, 2019
466c9ce
Merge branch 'master' into alt-src-reorganization
asahasrabuddhe Oct 9, 2019
2ff8978
Merge remote-tracking branch 'origin/master' into v3-alt-src
coilysiren Nov 18, 2019
d62f072
Merge branch 'master' into v3-alt-src
coilysiren Nov 28, 2019
c5f50db
Merge branch 'master' into v3-alt-src
coilysiren Nov 29, 2019
1f19a1b
Merge branch 'master' into v3-alt-src
asahasrabuddhe Jan 30, 2020
aacc63a
fix imports
asahasrabuddhe Jan 30, 2020
199d8a8
add missing refute function
asahasrabuddhe Jan 30, 2020
6f0113f
fix gofmt for helpers_test
asahasrabuddhe Jan 30, 2020
7e74963
change path to D: to support github actions
asahasrabuddhe Jan 30, 2020
78f51b6
fix flag name prefixer test
asahasrabuddhe Jan 30, 2020
ce9974b
fix missing test cases and apply linter fixes
asahasrabuddhe Jan 30, 2020
ddb40f4
fix go imports
asahasrabuddhe Jan 30, 2020
338d2e1
cleanup altsrc incoming code
asahasrabuddhe Jan 30, 2020
120695c
enable actions on v3 development branch
asahasrabuddhe Jan 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@ on:
branches:
- master
- v1
- v3-development-master
pull_request:
branches:
- master
- v1
- v3-development-master
Comment on lines +8 to +13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ (nice to have) can we name this just v3? For the sake of consistency 🙏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge deal either way, but I actually like having a name like v3-development-master that indicates a lack of stability compared to v3.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @rliebz it's just temporary. I will rename it once it's stable :)


jobs:

Expand Down
262 changes: 0 additions & 262 deletions altsrc/flag.go
View file
Open in desktop

This file was deleted.

Loading