Upgrade truffle, fix tests - #30
Conversation
| revision = ks.revision; | ||
| assert.equal(crypt, | ||
| '0xa000000000000000000000000000000000000000000000000000000000000000'); | ||
| '0x0a00000000000000000000000000000000000000000000000000000000000000'); |
There was a problem hiding this comment.
These right shifts are weird, happen in three places and no idea what causes this! Everything else is just boring breaking api changes.
There was a problem hiding this comment.
Looks like it's right-padding on the byte rather than half-byte or string level now?
|
Ping @jtobin. |
|
Thanks for this, @pkova! In case you haven't already, probably a good idea to see how these dependency changes interact with Bridge's repo & testing/dev scripts. |
jtobin
left a comment
jtobin
left a comment
There was a problem hiding this comment.
😍
Nice. I had just started to do some work on this myself (and then some -- see the jt/modernisation branch) before ducking offline on Thursday.
This LGTM -- the tests still seem to fail occasionally (#13), but this resolves the more egregious #28, with an updated truffle to boot.
Per @Fang-'s comment on downstream interaction, I'll hold off releasing a new version for the time being and do some other testing work, etc., before getting to that.
3 participants
Fixes #28, #13, #15.