Fixed Mongodb logging and charset bugs #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks 👍 and congratulations @LrsK for making your first WhatWeb bug fix! 🏆 |
|
@LrsK would you like to update the charset plugin version and add your name to the authors section? |
|
@urbanadventurer Thanks for the quick merge! Would it be possible to create a 0.5.1 release? I am using the code in a project and would rather lock in the code to a tagged version instead of pulling from master. |
|
I'm planning the 0.5.1 release but at this stage you would be better to use the master branch. |
|
@LrsK thanks for your help. I have tagged the 0.5.1 release now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logging to MongoDB was not working because it was still referring to the old naming of the output class.
In the charset plugin, the body was never referenced correctly, and for some reason the get_charset function was not able to be called inside the passive do-block, so I just pulled out the code and ran it directly since it was only called once anyway.
My knowledge of Ruby is very limited, but logging to MongoDB works now, as it did in version 0.4.9.