Skip to content

More robust displaycondition checking #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

jarekwg
Copy link
Member

@jarekwg jarekwg commented Nov 19, 2020

Initially the aim of this PR was going to be to broaden displaycondition logic to allow checking against attributes on related models, as well as M2Ms. However I noticed this'd come at a performance cost that probs isn't worth it..
So instead, this PR:

  • increases max length of DisplayCondition.values, to allow a larger amount of FKs to be thrown in there.. (not beautiful, but more performant)
  • increases explicitness in the code around which kind of fields are allowed to be checked by displayconditions.
  • squelches some errors that could've been coming out from the DisplayCondition logic previously, when bad conditions were provided.

@jarekwg jarekwg merged commit 6206a03 into master Nov 19, 2020
@jarekwg jarekwg deleted the fix/displaycondition-robustness branch November 19, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant