Conversation
Collaborator
Author
|
Great, thanks! I've submitted v1.1.0 to CRAN, will keep you posted. |
Collaborator
Author
|
Still a few platforms that haven't been checked / had binaries built yet.
ref: https://cran.r-project.org/web/checks/check_results_uptasticsearch.html I'll check back again later this week. |
Collaborator
Author
|
CRAN has built binaries for all the platforms it supports and only 2 checks ( That's good enough, let's merge this and finish the release. I've updated |
Collaborator
Author
|
Created the tag + release: https://github.com/uptake/uptasticsearch/releases/tag/v1.1.0 I think we're done here, thanks as always Austin 🤝 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Release v1.1.0.
It looks like
{futile.logger}ended up putting up a new release that fixes CRAN's checks (https://cran.r-project.org/web/packages/futile.logger/index.html), so no time pressure on this.But even with #259 a non-issue now, I still think we should do this to reduce the risk of something like it happening again.
{futile.logger}wasn't providing that much value here.Release checklist
Copied from #253
Before merging:
R CMD check) on this branchcran-comments.mdon this branch once the package is (hopefully) accepted and passing checksconda-forgerecipe (https://github.com/conda-forge/r-uptasticsearch-feedstock)After merging:
mainasv1.1.01.1.0.9999(update development version to 1.1.0.9999 #263)Notes for Reviewers
N/A