-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mapply was simplifying list of single row data tables to a matrix #263
Conversation
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
==========================================
+ Coverage 92.44% 92.46% +0.01%
==========================================
Files 12 12
Lines 927 929 +2
==========================================
+ Hits 857 859 +2
Misses 70 70
Continue to review full report at Codecov.
|
@TylerGrantSmith thanks! Could you elaborate on what the issue is? Did that simplification result in an error message or inaccurate result? Also, do you have a reproducible example that we could turn into a unit test, to prevent us from reintroducing the issue in the future? |
2031538
to
5cc4827
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this contribution, @TylerGrantSmith! I especially like the new silverstein
test package. A few minor revisions requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @TylerGrantSmith!
Addresses issue #260