feat(tasks): add missing API methods across 9 task classes#93
Open
flovntp wants to merge 9 commits into
Open
Conversation
Add methods identified as missing from task classes after comparing
against the OpenAPI spec and low-level generated APIs:
- MetricsTask: inject HttpTrafficApi, BlackfireMonitoringApi and
ContinuousProfilingApi; add httpMetricsTimeline*, blackfireServer*
and getContinuousProfiling* methods
- CertificatesTask: getProvisioner(), listProvisioners(),
updateProvisioner()
- EnvironmentsTask: deploy(), maintenanceRedeploy()
- OrganizationsTask: listReferencedOrgs/Projects, queryCarbon,
listSubscriptions and related billing/MFA helpers
- ProjectsTask: DeploymentTarget CRUD, Alerts, DomainClaims, carbon
query, usage alerts
- RegionsTask: listReferencedRegions() via ReferencesApi
- RepositoriesTask: listGitDiffs() via DiffApi
- ResourcesTask: patchAutoscalerSettings()
- TeamsTask: listReferencedTeams()
- UsersTask: getCurrentUserDeprecated(), createProfilePicture(),
getAccessDocument(), listReferencedUsers()
UpsunClient: instantiate and inject HttpTrafficApi,
BlackfireMonitoringApi, ContinuousProfilingApi, DiffApi for the
updated task constructors.
fix(templates): add missing FormDataProcessor import and 'object' deserialize case
- api.mustache: add use {{invokerPackage}}\FormDataProcessor so all
generated API classes that use FormDataProcessor have the correct
import after regeneration
- ObjectSerializer.mustache: add case 'object': return (object)$data
in deserialize() switch to handle generic object return types
Fix FormDataProcessor missing import in UserProfilesApi (generated).
Fix ObjectSerializer missing 'object' case in deserialize() (generated).
Tests: add 31 new test methods across 11 existing test files to cover
all added methods; fix MetricsTaskTest, TaskContainersTaskTest and
SystemOperationsTaskTest which were mocking final classes.
636 tests pass, 0 failures.
Collaborator
🧾 API Coverage ReportLast updated: dba332c • Run #236
📋 Full JSON report |
Upsun SDK checker reportDisplay raw output |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Upsun SDK checker reportDisplay raw output |
1 similar comment
Upsun SDK checker reportDisplay raw output |
Upsun SDK checker reportDisplay raw output |
Upsun SDK checker reportDisplay raw output |
Upsun SDK checker reportDisplay raw output |
Upsun SDK checker reportDisplay raw output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add methods identified as missing from task classes after comparing against the OpenAPI spec and low-level generated APIs:
UpsunClient: instantiate and inject HttpTrafficApi, BlackfireMonitoringApi, ContinuousProfilingApi, DiffApi for the updated task constructors.
fix(templates): add missing FormDataProcessor import and 'object' deserialize case
Fix FormDataProcessor missing import in UserProfilesApi (generated). Fix ObjectSerializer missing 'object' case in deserialize() (generated).
Tests: add 31 new test methods across 11 existing test files to cover all added methods; fix MetricsTaskTest, TaskContainersTaskTest and SystemOperationsTaskTest which were mocking final classes.
636 tests pass, 0 failures.