-
Notifications
You must be signed in to change notification settings - Fork 19
DX-2211: Fix CI Tests #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f989727 to
832a879
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves CI stability and fixes several configuration issues across multiple framework examples:
- Migrates test runner from Bun to Vitest to resolve request handling issues
- Adds missing Express type definitions
- Fixes SvelteKit build errors by removing
preserveSymlinksand adjusting Node version - Standardizes test configuration and reduces test flakiness
Reviewed Changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tsup.config.ts | Adds "express" to external dependencies list |
| src/constants.ts | Updates version from v0.2.21 to v0.2.22 |
| examples/sveltekit/vite.config.ts | Removes preserveSymlinks configuration |
| examples/sveltekit/svelte.config.js | Removes outdated adapter comments |
| examples/sveltekit/package.json | Adds Vitest dependencies and switches from file: to latest package version |
| examples/sveltekit/ci.test.ts | Migrates from Bun to Vitest test imports and adjusts timeout syntax |
| examples/nextjs/package.json | Adds Vitest dependencies and zod package |
| examples/nextjs/ci.test.ts | Migrates test imports from Bun to Vitest |
| examples/nextjs-pages/package.json | Adds Vitest dependencies |
| examples/nextjs-pages/ci.test.ts | Migrates test imports and adjusts timeout syntax |
| examples/fastify/package.json | Switches from file: to latest package version |
| examples/express/vitest.config.ts | Creates new Vitest configuration file |
| examples/express/package.json | Adds Express type definitions and Vitest dependencies |
| examples/express/ci.test.ts | Migrates from Bun to Vitest and adds dotenv import |
| examples/cloudflare-workers-hono/package.json | Updates Vitest version and adds test scripts |
| examples/cloudflare-workers-hono/ci.test.ts | Migrates test imports and adjusts timeout syntax |
| examples/ci/package.json | Adds Vitest dependencies and pins workflow version |
| examples/ci/app/ci/utils.test.ts | Migrates test imports from Bun to Vitest |
| examples/ci/app/ci/upstash/redis.test.ts | Migrates to Vitest with async test handling and fixes test structure |
| examples/ci/app/ci/ci.test.ts | Migrates test imports and adjusts timeout syntax |
| .github/workflows/test.yaml | Replaces Bun with pnpm/Vitest across all CI jobs |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Will fix issues in express and sveltekit:
Fixed it by removing preserveSymLinks: true