Skip to content

Conversation

@CahidArda
Copy link
Collaborator

@CahidArda CahidArda commented Oct 15, 2025

Will fix issues in express and sveltekit:

[vite]: Rollup failed to resolve import "esm-env" from "/vercel/path0/node_modules/svelte/src/internal/server/index.js".

Fixed it by removing preserveSymLinks: true

  • reduce flakiness of tests
  • used vitest instead of bun to address the requests getting stuck. Couldn't understand the underlying issue but switching to vitest solved the issues.

@CahidArda CahidArda requested a review from Copilot October 21, 2025 18:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves CI stability and fixes several configuration issues across multiple framework examples:

  • Migrates test runner from Bun to Vitest to resolve request handling issues
  • Adds missing Express type definitions
  • Fixes SvelteKit build errors by removing preserveSymlinks and adjusting Node version
  • Standardizes test configuration and reduces test flakiness

Reviewed Changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tsup.config.ts Adds "express" to external dependencies list
src/constants.ts Updates version from v0.2.21 to v0.2.22
examples/sveltekit/vite.config.ts Removes preserveSymlinks configuration
examples/sveltekit/svelte.config.js Removes outdated adapter comments
examples/sveltekit/package.json Adds Vitest dependencies and switches from file: to latest package version
examples/sveltekit/ci.test.ts Migrates from Bun to Vitest test imports and adjusts timeout syntax
examples/nextjs/package.json Adds Vitest dependencies and zod package
examples/nextjs/ci.test.ts Migrates test imports from Bun to Vitest
examples/nextjs-pages/package.json Adds Vitest dependencies
examples/nextjs-pages/ci.test.ts Migrates test imports and adjusts timeout syntax
examples/fastify/package.json Switches from file: to latest package version
examples/express/vitest.config.ts Creates new Vitest configuration file
examples/express/package.json Adds Express type definitions and Vitest dependencies
examples/express/ci.test.ts Migrates from Bun to Vitest and adds dotenv import
examples/cloudflare-workers-hono/package.json Updates Vitest version and adds test scripts
examples/cloudflare-workers-hono/ci.test.ts Migrates test imports and adjusts timeout syntax
examples/ci/package.json Adds Vitest dependencies and pins workflow version
examples/ci/app/ci/utils.test.ts Migrates test imports from Bun to Vitest
examples/ci/app/ci/upstash/redis.test.ts Migrates to Vitest with async test handling and fixes test structure
examples/ci/app/ci/ci.test.ts Migrates test imports and adjusts timeout syntax
.github/workflows/test.yaml Replaces Bun with pnpm/Vitest across all CI jobs

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@CahidArda CahidArda changed the title Fix: Improve CI DX-2211: Fix CI Tests Oct 22, 2025
@linear
Copy link

linear bot commented Oct 22, 2025

@CahidArda CahidArda merged commit 2095e83 into main Oct 23, 2025
22 checks passed
@CahidArda CahidArda deleted the fix/ci-errors branch October 23, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants