DX-1912: Add dlq restart resume #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytkimirti
reviewed
Jun 27, 2025
Comment on lines
+33
to
+48
| type PublicDLQMessage = Pick< | ||
| DLQMessage, | ||
| | "header" | ||
| | "body" | ||
| | "maxRetries" | ||
| | "notBefore" | ||
| | "createdAt" | ||
| | "callerIP" | ||
| | "workflowRunId" | ||
| | "workflowCreatedAt" | ||
| | "workflowUrl" | ||
| | "responseStatus" | ||
| | "responseHeader" | ||
| | "responseBody" | ||
| | "dlqId" | ||
| >; |
There was a problem hiding this comment.
I thought about this and wanted to use Pick. Becauase we may add fields to DLQMessage type to match the API but not realize that those fields end up in the public API.
In the current code, you need to explicitly write which fields should be in the public API
this makes it possible to access the error message in failure function via failResponse
CahidArda
commented
Jul 7, 2025
alitariksahin
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.