Skip to content

Fix for CVE-2024-52303 #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix for CVE-2024-52303 #53

wants to merge 2 commits into from

Conversation

ruchernchong
Copy link

@ruchernchong ruchernchong commented Nov 22, 2024 •
edited
Loading

Fixes CVE-2024-52304 as well

fahreddinozcan
fahreddinozcan approved these changes Nov 23, 2024
View reviewed changes
Copy link
Contributor

@fahreddinozcan fahreddinozcan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ruchernchong, thanks for the contribution 🎊

@fahreddinozcan
Copy link
Contributor

There seems to be an issue with the CI. The tests needs to pass before merging. I will try to have a look on monday to update the CI.

@ruchernchong
Copy link
Author

@fahreddinozcan I have fixed the potential CI issue. This fix requires python 3.9. I ran the poetry build and poetry run pytest on local and both worked fine.

@mdumandag
Copy link
Contributor

Closing this in favor of #58. There, I used a recent version of httpx instead of requests+aiohttp, which does not have this CVE

@mdumandag mdumandag closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fahreddinozcan fahreddinozcan fahreddinozcan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruchernchong @fahreddinozcan @mdumandag