-
Notifications
You must be signed in to change notification settings - Fork 1
DX-1485: Multi tabs and search history #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses DX-1485 by introducing multi-tab functionality and enhancing search history behavior in the databrowser.
- Replaces several usages of useDatabrowserStore with useRedis or useTab to improve separation of concerns
- Enhances the SearchInput component with keyboard navigation and history deduplication
- Refines UI styling and scroll behaviors for a smoother user experience
Reviewed Changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/components/databrowser/hooks/use-delete-key.ts | Swaps useDatabrowser for useRedis to obtain the Redis client |
src/components/databrowser/hooks/use-delete-key-cache.ts | Replaces store selection functionality with useTab |
src/components/databrowser/hooks/use-add-key.ts | Updates to useRedis for key addition logic |
src/components/databrowser/components/tab-type-icon.tsx | Introduces a new component for rendering type tags with a skeleton loader |
src/components/databrowser/components/sidebar/type-selector.tsx | Switches state retrieval from useDatabrowserStore to useTab |
src/components/databrowser/components/sidebar/search-input.tsx | Implements enhanced search input with history management and keyboard navigation |
src/components/databrowser/components/sidebar/keys-list.tsx | Adopts useTab for selected key management and improves key item styling |
src/components/databrowser/components/sidebar/infinite-scroll.tsx | Adds additional props support and refines ScrollArea styling |
src/components/databrowser/components/sidebar/index.tsx | Adjusts layout and integrates updated InfiniteScroll behavior |
src/components/databrowser/components/sidebar/db-size.tsx | Updates Redis usage to useRedis |
Other display and modal components | Harmonizes state management with useTab and refines UI components accordingly |
package.json | Bumps the version of @radix-ui/react-dropdown-menu |
Comments suppressed due to low confidence (1)
src/components/databrowser/components/sidebar/infinite-scroll.tsx:10
- The InfiniteScroll component receives a 'roundedInherit' prop from its parent but does not currently use it to modify its styling. Consider handling this prop explicitly or removing it to avoid confusion.
...{...props}
No description provided.