Redis JSON SDK documentation fixes #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
as-celegen
commented
Feb 17, 2025
as-celegen
commented
- Most of the json functions return as array because of the possibility of wildcard usage
- Some examples were missing function name and just written as "redis.json(..."
- Some files had parameters leftover from copy-pasting and some had leftover parameter or return value descriptions
|
@mdumandag can you review please |
mdumandag
reviewed
Feb 19, 2025
There was a problem hiding this comment.
For the Python SDK, we don't support the JSON commands yet. So, I am not sure why we have documentation for it 😄
I see that it was added in this PR, and we just copy pasted the TS SDK docs. So, we should remove all JSON commands from the Python SDK documentation.
|
I have also implemented JSON commands and created a PR for it and tried to write the documentation based on it. If you are interested that one can be reviewed first. |
mdumandag
reviewed
Feb 26, 2025
mdumandag
approved these changes
Feb 27, 2025
|
@enesakar if possible can you assign someone to review Typescript SDK changes? |
|
@CahidArda can you check ts sdk changes? |
CahidArda
reviewed
Mar 18, 2025
CahidArda
approved these changes
Mar 19, 2025
|
Changes are fine by me, we can merge @enesakar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.