Open
Description
Summary
The build is broken on two issues:
- Setup steps in
scripts/install_podman.sh
are not needed on Ubuntu 20.10+ because it includes podman out-of-the-box. - rspec-its 2.0 switches from
send
topublic_send
, breaking a test.
This is a blocker issue as it prevents other bugfixes or features from being merged.
Details
podman available by default on Ubuntu 20.10+
The key and package URLs used by install_podman.sh no longer exist. Since podman is available by default on Ubuntu 20.10+, those steps can simply be removed.
rspec-its send -> public_send
rspec-its v2.0 (released Nov. 4, 2024) breaks the Docker::Connection#resource resource
test because its
now uses public_send
rather than send
. See this build for an example:
Failures:
1) Docker::Connection#resource resource
Failure/Error: its(:resource) { should be_a Excon::Connection }
NoMethodError:
private method `resource' called for an instance of Docker::Connection
# ./spec/docker/connection_spec.rb:69:in `block (3 levels) in <top (required)>'
Finished in 1 minute 41.17 seconds (files took 0.32033 seconds to load)
235 examples, 1 failure, 12 pending
It's dubious whether resource
should be private or this test should even exist, but given the current behavior the easiest fix is to pin rspec-its to 1.x.
Metadata
Metadata
Assignees
Labels
No labels