Skip to content

Conversation

@jisundr
Copy link
Contributor

@jisundr jisundr commented Oct 5, 2022

Closes #23

  • Set up lint and test.
  • Fix lint errors and warnings.
  • Merge workflows into react-todo-ci.yml
    • Trigger lint and test checks on push.
    • Trigger build storybook and deploy to GH pages on push in the master branch.
    • Trigger build a package and publish to NPM on push in the master branch.

Let me know if you encounter a problem when merging this PR during deployment. @kamalkishor1991 for review. Thanks.

@kamalkishor1991
Copy link
Contributor

Thanks @jisundr for taking this up. Added few minor comments/questions. Please check.

@jisundr jisundr force-pushed the setup-github-actions branch from 093452f to cd1b25b Compare October 5, 2022 23:27
@jisundr jisundr force-pushed the setup-github-actions branch from cd1b25b to 72b835b Compare October 6, 2022 00:12
@jisundr
Copy link
Contributor Author

jisundr commented Oct 6, 2022

@kamalkishor1991 this is updated. please review. thanks.

@kamalkishor1991 kamalkishor1991 merged commit 51e5e79 into upnotes-io:master Oct 6, 2022
@kamalkishor1991
Copy link
Contributor

Thanks @jisundr. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add jest tests with github action to execute test on every PR and merge

2 participants