moved 'react-syntax-highlighter' to devDependencies#33
Closed
mikaello wants to merge 10 commits intoupmostly:masterfrom
Closed
moved 'react-syntax-highlighter' to devDependencies#33mikaello wants to merge 10 commits intoupmostly:masterfrom
mikaello wants to merge 10 commits intoupmostly:masterfrom
Conversation
Using command: npm install react-syntax-highlighter@10.2.1 --save-dev
mikaello
force-pushed
the
move-react-syntax-highlighter-to-dev-dependencies
branch
from
dca3ad9 to
4fc4866
Compare
option is now mandatory as prop to Modal, and default value of empty object is given to useModali
remove shortid dep and use user given key instead
add PropTypes for modal component
Update readme
Remove unecessary option check
Contributor
Author
|
Ah, sorry, all these commits does not belong to this branch. I have mistakenly been committing to this branch, only the commit Sorry for the mess! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using command:
npm install react-syntax-highlighter@10.2.1 --save-devreact-syntax-highlighteris used in examples only, not in the library itself. Adds unnecessary dependency tree.Resolving issue #28