chore: enable noImplicitAny
#519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nd0ut
force-pushed
the
chore/enable-no-implicit-any
branch
12 times, most recently
from
693f5ad
to
87c11c2
Compare
nd0ut
force-pushed
the
chore/enable-no-implicit-any
branch
from
87c11c2
to
77e053e
Compare
egordidenko
reviewed
Feb 20, 2024
| @@ -19,22 +24,39 @@ const calcShrinkSteps = function (sourceW, targetW, targetH, step) { | |||
| return steps.reverse() | |||
| } | |||
|
|
|||
| export const fallback = ({ img, sourceW, targetW, targetH, step }) => { | |||
| export const fallback = ({ | |||
There was a problem hiding this comment.
Let's create type
TFallback = {
img: HTMLImageElement
sourceW: number
targetW: number
targetH: number
step: number
}
| @@ -1,7 +1,12 @@ | |||
| import { testCanvasSize } from '../canvas/testCanvasSize' | |||
| import { canvasResize } from '../canvas/canvasResize' | |||
|
|
|||
| const calcShrinkSteps = function (sourceW, targetW, targetH, step) { | |||
| const calcShrinkSteps = function ( | |||
There was a problem hiding this comment.
Might it be worth converting to obj? And we can use types Omit<TFallback, "img">
| img, | ||
| targetW, | ||
| targetH | ||
| }: { |
There was a problem hiding this comment.
And here you can describe the types via TNative
Chore/image-shrink-types
chore: testing setup for image shrink
egordidenko
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.