Skip to content

Update Callback type hint #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

risantos
Copy link
Member

@risantos risantos commented Jul 2, 2025

Description

  • Clarify the callback method's requirements by specifying that class names on customClass must match the pattern /^[a-zA-Z\d]+$/. This enhances type safety and documentation for users of the interface.

New type signature

image

@Copilot Copilot AI review requested due to automatic review settings July 2, 2025 16:54
@risantos risantos self-assigned this Jul 2, 2025
@risantos risantos requested a review from franciscocardoso July 2, 2025 16:54
@risantos risantos requested review from a team as code owners July 2, 2025 16:54
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

- Specify the `customClass` parameter's expected format.
- Add example usage for clarity.
@risantos risantos force-pushed the support/update-callback-type-hint branch from f05ebf2 to f246019 Compare July 15, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant