Skip to content

Add ABA account number assert #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions src/asserts/aba-account-number-assert.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
'use strict';

/**
* Module dependencies.
*/

const { Validator, Violation } = require('validator.js');

/**
* Account number regex.
*/

const accountNumberRegex = /^[a-zA-Z0-9]{5,17}$/;

/**
* Export `AbaAccountNumberAssert`.
*/

module.exports = function abaAccountNumberAssert() {
/**
* Class name.
*/

this.__class__ = 'AbaAccountNumber';

/**
* Validation algorithm.
*/

this.validate = value => {
if (typeof value !== 'string') {
throw new Violation(this, value, { value: Validator.errorCode.must_be_a_string });
}

if (!accountNumberRegex.test(value)) {
throw new Violation(this, value);
}

return true;
};

return this;
};
2 changes: 2 additions & 0 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* Module dependencies.
*/

const AbaAccountNumber = require('./asserts/aba-account-number-assert');
const AbaRoutingNumber = require('./asserts/aba-routing-number-assert.js');
const BankIdentifierCode = require('./asserts/bank-identifier-code-assert.js');
const BigNumber = require('./asserts/big-number-assert.js');
Expand Down Expand Up @@ -48,6 +49,7 @@ const Uuid = require('./asserts/uuid-assert.js');
*/

module.exports = {
AbaAccountNumber,
AbaRoutingNumber,
BankIdentifierCode,
BigNumber,
Expand Down
63 changes: 63 additions & 0 deletions test/asserts/aba-account-number-assert.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
'use strict';

/**
* Module dependencies.
*/

const { Assert: BaseAssert, Violation } = require('validator.js');
const AbaAccountNumberAssert = require('../../src/asserts/aba-account-number-assert');

/**
* Extend `Assert` with `AbaAccountNumberAssert`.
*/

const Assert = BaseAssert.extend({
AbaAccountNumber: AbaAccountNumberAssert
});

/**
* Test `AbaAccountNumberAssert`.
*/

describe('AbaAccountNumberAssert', () => {
it('should throw an error if the input value is not a string', () => {
[{}, []].forEach(choice => {
try {
Assert.abaAccountNumber().validate(choice);

fail();
} catch (e) {
expect(e).toBeInstanceOf(Violation);
expect(e.violation.value).toBe('must_be_a_string');
}
});
});

it('should throw an error if the input value is not a valid ABA account number', () => {
try {
Assert.abaAccountNumber().validate('foo');

fail();
} catch (e) {
expect(e).toBeInstanceOf(Violation);
expect(e.show().value).toBe('foo');
}
});

it('should expose `assert` equal to `AbaAccountNumber`', () => {
try {
Assert.abaAccountNumber().validate(123);

fail();
} catch (e) {
expect(e.show().assert).toBe('AbaAccountNumber');
}
});

it.each(['76175925', '76175925761759257', '76175', 'abcdefghijklmnopq', 'abcde', 'ABcDeFGH'])(
'should accept a valid ABA account number',
accountNumber => {
Assert.abaAccountNumber().validate(accountNumber);
}
);
});
2 changes: 1 addition & 1 deletion test/asserts/aba-routing-number-assert.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const Assert = BaseAssert.extend({
});

/**
* Test `RoutingNumberAssert`.
* Test `AbaRoutingNumberAssert`.
*/

describe('AbaRoutingNumberAssert', () => {
Expand Down
3 changes: 2 additions & 1 deletion test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,10 @@ describe('validator.js-asserts', () => {
it('should export all asserts', () => {
const assertNames = Object.keys(asserts);

expect(assertNames).toHaveLength(38);
expect(assertNames).toHaveLength(39);
expect(assertNames).toEqual(
expect.arrayContaining([
'AbaAccountNumber',
'AbaRoutingNumber',
'BankIdentifierCode',
'BigNumber',
Expand Down