Add lint staged #12
Merged
Add lint staged #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rplopes
reviewed
Dec 27, 2018
nunofgs
force-pushed
the
enhancement/add-lint-staged
branch
from
c3380f8 to
b5f8089
Compare
waldyrious
force-pushed
the
enhancement/add-lint-staged
branch
2 times, most recently
from
4373a65 to
38ba78b
Compare
waldyrious
reviewed
Jan 9, 2020
Contributor
|
Perhaps the PR needs to be updated again since some time as passed, but what’s the reason it hasn’t been merged for all these years? |
satazor
force-pushed
the
enhancement/add-lint-staged
branch
from
38ba78b to
e861416
Compare
Contributor
|
Updated the PR. @nunofgs can you give this a last review before merging? I've tested this out manually and is working as intended. |
Contributor
|
Unrelated to this PR but this line: Line 8 in 9a544e1 pre-commit, that line should be on every root project that uses uphold-scripts and not here.
|
Contributor
|
Should we consider adding |
satazor
force-pushed
the
enhancement/add-lint-staged
branch
from
e861416 to
eba61b9
Compare
Author
|
LGTM. |
nunofgs
commented
Feb 21, 2022
Currently, linting runs on every pre-commit for the whole project. This can be slow for medium to large sized projects. With lint-staged, linting runs only on git staged files.
satazor
force-pushed
the
enhancement/add-lint-staged
branch
from
eba61b9 to
c815dda
Compare
satazor
approved these changes
Feb 21, 2022
Contributor
|
🚀 |
Contributor
You should know the answer by heart right now 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint-staged package implements a mechanism for running linters only against git changes staged for commit (rather than the entire codebase), as a pre-commit hook.