Add authentication sample using PAT #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inginheiiro
force-pushed
the
enhancement/add-auhentication-samples-PAT
branch
2 times, most recently
from
d51cad9 to
10bf97e
Compare
inginheiiro
changed the title
waldyrious
force-pushed
the
enhancement/add-auhentication-samples-PAT
branch
from
a7f1169 to
8b1f741
Compare
waldyrious
approved these changes
Nov 10, 2020
There was a problem hiding this comment.
Rebased this on the latest master branch, and applied a few improvements:
- Renamed the directory from
client-credential-pattopersonal-access-token - Expanded the README and the code comments
- Replaced the custom OTP code with the 000000 special value for Sandbox
- Reworded some variables to avoid redundancy, e.g.
OTPTokenandPATToken - Added a
.gitignorefile - Removed the unnecessary content-type header for a request without body
- Various other small adjustments
Overall, LGTM.
- Reword a passage in the README for improved clarity - Adjust whitespace in various files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.