Skip to content

Conversation

@rplopes
Copy link
Contributor

@rplopes rplopes commented Jul 10, 2018

Change this project's licence from private to MIT and adapt accordingly.

This is in preparation to making this repository public and to publish this module on the NPM registry.

Should we add anything else we like to have on our own open source projects?

@rplopes rplopes self-assigned this Jul 10, 2018
@rplopes rplopes requested review from Americas and kurayama July 10, 2018 18:33
@@ -1 +0,0 @@
(c) Copyright 2017 Uphold, Inc. All rights reserved.

This comment was marked as resolved.

Copy link
Contributor

@Americas Americas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing .npmignore.

Ex.:

*
!src
!CHANGELOG.md
!LICENSE
!README.md
!package.json
!yarn.lock

@rplopes rplopes force-pushed the support/prepare-to-open-source branch from 9d25a79 to 9f78eaa Compare July 11, 2018 10:43
@rplopes
Copy link
Contributor Author

rplopes commented Jul 11, 2018

Added .npmignore.

"name": "@uphold/http-errors",
"version": "1.1.0",
"description": "Set of errors based on http-standard-error",
"license": "SEE LICENSE IN LICENSE",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@rplopes rplopes force-pushed the support/prepare-to-open-source branch from 9f78eaa to fe9d9e3 Compare July 11, 2018 16:01
@Americas Americas merged commit 28299cb into master Jul 11, 2018
@Americas Americas deleted the support/prepare-to-open-source branch July 11, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants