Initial implementation #1
Conversation
ricardogama
force-pushed
the
feature/initial-implementation
branch
from
543c023 to
08d10e2
Compare
test/index_test.js
Outdated
| UnauthorizedError, | ||
| ValidationFailedError | ||
| }); | ||
| }); |
There was a problem hiding this comment.
We can probably get rid of this test if we use the errors exported by the index in the other tests, i.e. changing from:
const ValidationFailedError = require('../../src/errors/validation-failed-error');to
const { ValidationFailedError } = require('../../src');| it('should add custom properties', () => { | ||
| expect(new UnauthorizedError({ foo: 'bar' }).foo).toBe('bar'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
3 out of 5 of these tests are common across the default HTTP errors. Is it possible to abstract them somehow, to avoid the duplication and the potential overlooked typos?
For instance, isolating them inside a util method, and in these HTTP error test files calling that util method. Just a suggestion, don't even know if that works with jest.
There was a problem hiding this comment.
Check the test util I created!
|
Add errors for codes 409 and 500 as well? |
ricardogama
force-pushed
the
feature/initial-implementation
branch
from
08d10e2 to
96d711e
Compare
|
@rplopes Added 409 and 410 errors, and left 500 out since it does not seem a common use case as we discussed online. |
ricardogama
force-pushed
the
feature/initial-implementation
branch
from
96d711e to
8f588af
Compare
This PR adds the initial implementation of this module with the following errors: