Add RabbitMQ High Availability connection support #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaitodor
force-pushed
the
ha-support
branch
4 times, most recently
from
3d50211 to
2608f52
Compare
|
@mihaitodor Feel free to update the update the deps, and we will be able to merge this PR then. |
- Support the new signature for NewRabbitMQTransport
mihaitodor
force-pushed
the
ha-support
branch
from
2608f52 to
e588e0a
Compare
|
@AlexisMontagne Sorry for the long delay. I finally managed to look into this and updated the dependencies as you requested. However, I'm not 100% sure it went well, because I had a lot of trouble figuring out which version of Godeps you are using in combination with Go 1.4... The latest version fails to update the 3 dependencies from sensu-go, so I tried to use an older version and to re-create the whole Godeps folder from scratch via |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to add basic support for RabbitMQ High Availability (see #13).
Limitations / TODOs for future PRs: