feat(mcp): add option to upgrade mcp configuration version#10
Merged
haarchri merged 2 commits intoupbound:mainfrom Nov 2, 2023
Merged
feat(mcp): add option to upgrade mcp configuration version#10haarchri merged 2 commits intoupbound:mainfrom
haarchri merged 2 commits intoupbound:mainfrom
Conversation
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
darkmuggle
approved these changes
Oct 25, 2023
Contributor
darkmuggle
left a comment
There was a problem hiding this comment.
A couple of nits, but nothing to block on.
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
introduced a new feature in this PR that allows you to update MCP control plane configuration versions in two ways:
versionautoUpdate: true.If you want to control the exact version of the configuration that's running, use the specific version option. Alternatively, if you prefer automatic updates whenever a new configuration is available, you can use the autoUpdate option. Keep in mind that you have the option to utilize crossplane composition revisions, which is preferred when using the autoUpdate feature.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Create Controlplane:
—
New configuration version available:
—
Update Controlplane:
—
Create Controlplane with autoUpdate:
—