Move code that accesses public_suffix_list::root_ to .cpp file
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable `root_` is of type `label_item` struct, containing a member named `children`. The type of `children` differs depending on whether the code is compiled with C++17 or C++20. It is possible to encounter a situation where the Upa URL library is compiled using a C++17 compiler, but is then integrated into a program compiled with C++20. In such cases, it is important that all code accessing `root_` is compiled using the same C++ standard, prompting the implementation of this fix.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
=======================================
Coverage 99.66% 99.66%
=======================================
Files 16 16
Lines 2671 2675 +4
Branches 424 424
=======================================
+ Hits 2662 2666 +4
Misses 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable
root_is of typelabel_itemstruct, containing a member namedchildren. The type ofchildrendiffers depending on whether the code is compiled with C++17 or C++20. It is possible to encounter a situation where the Upa URL library is compiled using a C++17 compiler, but is then integrated into a program compiled with C++20. In such cases, it is important that all code accessingroot_is compiled using the same C++ standard, prompting the implementation of this fix.