OAS Diff html report based on react with new design - #4
Merged
Conversation
leon-up9
changed the title
leon-up9
marked this pull request as ready for review
May 22, 2022 08:31
Contributor
Author
|
We should mention in some place that "go build" won't work (after this merge), and to build the executable should be only with "make build". |
| type EnumDictionary<T extends string | symbol | number, U> = { | ||
| [K in T]: U; | ||
| }; | ||
| export const TypeCaptionDictionary: EnumDictionary<string, string> = { |
There was a problem hiding this comment.
try to use https://stackoverflow.com/questions/6215349/getting-corresponding-enum-key-for-the-value-passed or other solution
for taking the enum key by value
| export const deleteClass = ChangeTypeEnum.Deleted | ||
| export const infoClass = "info" | ||
|
|
||
| type EnumDictionary<T extends string | symbol | number, U> = { |
added 2 commits
May 23, 2022 15:09
lirazyehezkel
approved these changes
May 24, 2022
Closed
IgorGov
commented
May 24, 2022
| "inline-chunk-html-plugin": "^1.1.1", | ||
| "react": "^18.1.0", | ||
| "react-dom": "^18.1.0", | ||
| "@mui/styles": "^5.8.0", |
Contributor
Author
There was a problem hiding this comment.
"make build" will generate changes in package-lock.json
gustavomassa
approved these changes
May 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.