Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started as an experiment to see if we can move this chunk of code from
scripts.html
into the rest of the client-side JS:up-for-grabs.net/_includes/scripts.html
Lines 72 to 82 in b020dc2
This code:
projects
as a global objectThis is immediately used inside
main.js
as state for theProjectsService
:up-for-grabs.net/javascripts/main.js
Lines 13 to 15 in b020dc2
And
projectsSvc
is used in many places inside the script.So before I look at moving that first snippet into the rest of the app, I wanted to tidy up how the app is composed using the
projects
global:projectService
wherever needed, avoiding the globalTODO: