fixed the broken "popular tags" (#1179)

* fixed so that you can click on the popular tags to filter with them * fixed linter errors * liiiint * eslint and prettier cannot agree, so tidy this up to be consistent
up-for-grabs · Sep 26, 2019 · e1ddc9e · e1ddc9e
1 parent 08a16ee
commit e1ddc9e
Showing 1 changed file with 14 additions and 6 deletions.
diff --git a/javascripts/main.js b/javascripts/main.js
@@ -91,12 +91,20 @@ define([
           selTags = $('.tags-filter').val() || [];
           selectedTag = preparePopTagName($(this).text() || '');
           if (selectedTag) {
-            selTags.push(selectedTag);
-            location.href = updateQueryStringParameter(
-              getFilterUrl(),
-              'tags',
-              encodeURIComponent(selTags)
-            );
+            tagID = projectsSvc
+              .getTags()
+              .map(function(tag) {
+                return tag.name.toLowerCase();
+              })
+              .indexOf(selectedTag);
+            if (tagID !== -1) {
+              selTags.push(selectedTag);
+              location.href = updateQueryStringParameter(
+                getFilterUrl(),
+                'tags',
+                encodeURIComponent(selTags)
+              );
+            }
           }
         });
       });