create recovery timer mechanism #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahSprenger
requested changes
Mar 23, 2024
NoahSprenger
reviewed
May 4, 2024
NoahSprenger
reviewed
May 4, 2024
boards/recovery/src/main.rs
Outdated
| let timerclk: hal::clock::v1::Tc2Tc3Clock = pclk_tc2tc3.into(); | ||
| let mut recovery_timer = | ||
| hal::timer::TimerCounter2::tc2_(&timerclk, peripherals.TC2, &mut mclk); | ||
| recovery_timer.enable_interrupt(); |
There was a problem hiding this comment.
We don't want to enable interrupts here, just create the timer object.
boards/recovery/src/main.rs
Outdated
| data.recovery_counter += 1; | ||
| }); | ||
| } | ||
| // restart timer after interrupt |
There was a problem hiding this comment.
This logic should be inside the if statement, not outside of it. This is because the timer interrupt can fire for multiple reasons and right now you are restarting the time for any and all interrupts, not just the case that it is finished.
| @@ -8,6 +8,7 @@ use messages::command::{Command, PowerDown, RadioRate, RadioRateChange}; | |||
| use messages::sender::Sender::SensorBoard; | |||
| use messages::Message; | |||
| use rtic::mutex::Mutex; | |||
| use atsamd_hal::prelude::_atsamd_hal_timer_traits_InterruptDrivenTimer; | |||
There was a problem hiding this comment.
Do you know why this was needed? What is the error if you do not include this?
NoahSprenger
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.