Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CC-1377] add new paypage #192

Merged
merged 14 commits into from
Aug 22, 2024
Merged

[CC-1377] add new paypage #192

merged 14 commits into from
Aug 22, 2024

Conversation

Ryouzanpaku
Copy link
Contributor

No description provided.

- Create basic paypage v2 resource
- add authorization handling for different apis.
- Add basic integration test.
- add properties with primitive data types.
- Add Urls, Style and Paymentmethodsconfigs properties.
- Add resources property.
@Ryouzanpaku Ryouzanpaku changed the title Cc 1377/add new paypage [CC-1377] add new paypage Aug 16, 2024
Copy link

github-actions bot commented Aug 16, 2024

Logo
Checkmarx One – Scan Summary & Detailsb940e4e1-2acb-474d-9eeb-44f0affe36eb

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /test-group.yml: 27 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

- enable paypage fetching.
- assign test groups
- assign test groups
- assign test groups.
- update methodConfig
- Add method to easier add method config.
- add test with label method config.
- Add workflow to run specific test groups (including unit and integration tests)
@Ryouzanpaku Ryouzanpaku marked this pull request as ready for review August 20, 2024 09:25
$unzer = $this->getUnzerObject();
$risk = new RiskData();

$risk->setThreatMetrixId('f544if49wo4f74ef1x')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only support these fields in risk:
"risk": {
"registrationLevel": "string",
"registrationDate": "string",
"customerGroup": "top",
"confirmedOrders": 0,
"confirmedAmount": 0
}

customerId and threatmetrixId are gone.
ThreadMetrixId will be generated by the Paypage UI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntonAtUnzer
I see, I reused the risk object for normal transactions here. So i can not remove them from the original class.
The merchant could just not set the properties. Or should i make sure that he is not setting them for paypage requests?

protected float $amount;
protected string $currency;

protected ?string $type = null;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkoutType as well e.g. full, payment_only, no_shipping

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add checkout type to paypage.
  • Remove checkout type from method config.

- Add checkout type to paypage.
- Remove checkout type from method config.
- Split up riskdata object to have one version for normal transaction requests and one for paypage creation requests.
@Ryouzanpaku Ryouzanpaku merged commit 550b2e6 into main Aug 22, 2024
9 checks passed
@Ryouzanpaku Ryouzanpaku deleted the CC-1377/add-new-paypage branch August 22, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants