fix language filtering to exclude unconfigured languages#290
Open
rathboma wants to merge 2 commits intountra:mainfrom
Open
fix language filtering to exclude unconfigured languages#290rathboma wants to merge 2 commits intountra:mainfrom
rathboma wants to merge 2 commits intountra:mainfrom
Conversation
Filter out documents with languages not in the configured languages array. When a site is configured with limited languages (e.g., ["en", "es"]), documents with other languages (e.g., "de") are now properly excluded from processing. Changes: - coordinate_documents: Add language validation with warning logs - assignPageLanguagePermalinks: Filter permalink_lang to configured languages only - i18n_headers tag: Filter hreflang metadata to configured languages - Add comprehensive test coverage for language filtering Fixes issue where unconfigured language documents could be selected as the version for configured languages. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Resolved conflict in site_spec.rb by keeping both the rendered_lang tests from main and the unconfigured languages tests from this branch. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
untra
reviewed
Feb 20, 2026
| # Skip unconfigured languages | ||
| next unless valid_languages.include?(doc_lang) | ||
| [doc_lang, doc.data['permalink']] | ||
| end.to_h |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter out documents with languages not in the configured languages array. When a site is configured with limited languages (e.g., ["en", "es"]), documents with other languages (e.g., "de") are now properly excluded from processing.
This is a problem in Beekeeper Studio because our full build takes ~10 minutes, but building for 2 languages takes less than a minute, so we limit languages in dev mode.