Repository navigation
Fix PSVR2 Sense thumbstick input never firing - #1261
Merged
Merged
Conversation
Each PSVR2 wand's single stick is exposed on GCPhysicalInputProfile under the generic "Thumbstick"/"Thumbstick Button" keys, not the GCExtendedGamepad-style "Left Thumbstick"/"Right Thumbstick" keys the handler was looking up, so those handlers were never attached. Route stick events into GameControllerState's left/right fields using the wand's ARKit-derived chirality, and document thumbstick reads in UsingInputSystem.md.
miogds
added a commit
to miolabs/UntoldEngine
that referenced
this pull request
Sep 28, 2026
Sync fork develop with upstream: PSVR2 Sense thumbstick input fix (untoldengine#1261)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"Thumbstick"/"Thumbstick Button"keys onGCPhysicalInputProfile, not the"Left Thumbstick"/"Right Thumbstick"keys the handler was looking up — so those handlers were never attached andleftThumbstickX/Y,rightThumbstickX/Y,leftThumbStickActive/rightThumbStickActive, andleftThumbstickPressed/rightThumbstickPressedstayed stuck at their default values.GameControllerState's left/right fields using each wand's ARKit-derived chirality (the same mechanism already used for PSVR2 pose tracking), since both wands share the same generic key.docs/API/UsingInputSystem.md.GameControllerState's public fields are unchanged, all touched code is private/internal to the module, and only the previously-dead PSVR2-stick code path is affected — non-PSVR2 controllers and PSVR2 buttons/triggers are untouched.Fixes #1260
Test plan
swift buildsucceedsswift test --filter PSVR2InputSystemTestspasses (9 tests, including 4 new ones covering left/right chirality routing, deadzone, click, and unresolved-controller safety)