Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dchan/dt 902 add ens resolution js #254

Merged
merged 29 commits into from
Oct 3, 2023

Conversation

DChan0319
Copy link
Contributor

Background

Need to add ENS support

Changes

Added ENS support and unit tests.

To Do

Need to refactor the resolution construction to not need ens

Additional Deployment and/or Rollback Steps

Code Review

This Pull Request was thoroughly reviewed and meets all Code Review Standards pertaining to:

  • Implementation - satisfied acceptance criteria
  • Communication - notified engineers/stakeholders about impactful changes
  • Error handling - handled, logged & alerted on errors
  • Documentation - wrote readable code & commits, documented unintuitive code
  • Testing - unit & E2E test coverage, tested in staging, DB migrations backwards compatible
  • Security - sanitized inputs, vetted dependencies, validated/secured API requests, no committed secrets
  • Performance - optimized expensive algorithms & database queries

Please select all applied standards relevant to this PR.

Confirmation

  • Assignee Confirmation - I (the author) have filled out the template above
  • Reviewer Confirmation - I (a/the reviewer) confirm 1) the author has filled out the template and checked the box that says Assignee Confirmation 2) I reviewed the code and selected all applicable items in the code review section.

@DChan0319 DChan0319 changed the title Dchan/dt 902 add ens resolution js [WIP]: Dchan/dt 902 add ens resolution js Sep 6, 2023
@DChan0319 DChan0319 force-pushed the dchan/DT-902-add-ens-resolution-js branch 4 times, most recently from ab63843 to 2896007 Compare September 6, 2023 22:14
@DChan0319 DChan0319 force-pushed the dchan/DT-902-add-ens-resolution-js branch from 2896007 to fd0ef8c Compare September 6, 2023 22:19
@DChan0319 DChan0319 changed the title [WIP]: Dchan/dt 902 add ens resolution js Dchan/dt 902 add ens resolution js Sep 7, 2023
@DChan0319 DChan0319 requested a review from a team September 7, 2023 20:30
README.md Outdated Show resolved Hide resolved
src/Ens.ts Outdated Show resolved Hide resolved
src/Ens.ts Outdated Show resolved Hide resolved
src/Ens.ts Outdated Show resolved Hide resolved
@DChan0319 DChan0319 force-pushed the dchan/DT-902-add-ens-resolution-js branch 4 times, most recently from 41c80fa to 7c3fd6f Compare September 14, 2023 15:02
src/Ens.ts Outdated Show resolved Hide resolved
@DChan0319 DChan0319 force-pushed the dchan/DT-902-add-ens-resolution-js branch from 6478e25 to 96a7fe2 Compare September 21, 2023 18:48
@DChan0319 DChan0319 force-pushed the dchan/DT-902-add-ens-resolution-js branch from 8a71fea to 2b5d780 Compare September 28, 2023 22:42
src/Ens.ts Outdated Show resolved Hide resolved
src/Ens.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@tunguyennnnn tunguyennnnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!
Can you add some examples of resolving .eth in readme?

@DChan0319 DChan0319 force-pushed the dchan/DT-902-add-ens-resolution-js branch from abe92d0 to 5348006 Compare October 3, 2023 04:52
@DChan0319 DChan0319 merged commit f19421a into master Oct 3, 2023
7 checks passed
@DChan0319 DChan0319 deleted the dchan/DT-902-add-ens-resolution-js branch October 3, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants