-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dchan/dt 902 add ens resolution js #254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0af264b.
DChan0319
changed the title
Dchan/dt 902 add ens resolution js
[WIP]: Dchan/dt 902 add ens resolution js
Sep 6, 2023
DChan0319
force-pushed
the
dchan/DT-902-add-ens-resolution-js
branch
4 times, most recently
from
September 6, 2023 22:14
ab63843
to
2896007
Compare
DChan0319
force-pushed
the
dchan/DT-902-add-ens-resolution-js
branch
from
September 6, 2023 22:19
2896007
to
fd0ef8c
Compare
DChan0319
changed the title
[WIP]: Dchan/dt 902 add ens resolution js
Dchan/dt 902 add ens resolution js
Sep 7, 2023
DChan0319
force-pushed
the
dchan/DT-902-add-ens-resolution-js
branch
4 times, most recently
from
September 14, 2023 15:02
41c80fa
to
7c3fd6f
Compare
DChan0319
force-pushed
the
dchan/DT-902-add-ens-resolution-js
branch
from
September 21, 2023 18:48
6478e25
to
96a7fe2
Compare
DChan0319
force-pushed
the
dchan/DT-902-add-ens-resolution-js
branch
from
September 26, 2023 21:55
dc20f93
to
2dcdb11
Compare
DChan0319
force-pushed
the
dchan/DT-902-add-ens-resolution-js
branch
from
September 28, 2023 22:42
8a71fea
to
2b5d780
Compare
tunguyennnnn
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good!
Can you add some examples of resolving .eth in readme?
DChan0319
force-pushed
the
dchan/DT-902-add-ens-resolution-js
branch
from
October 3, 2023 04:52
abe92d0
to
5348006
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Need to add ENS support
Changes
Added ENS support and unit tests.
To Do
Need to refactor the resolution construction to not need ens
Additional Deployment and/or Rollback Steps
Code Review
This Pull Request was thoroughly reviewed and meets all Code Review Standards pertaining to:
Please select all applied standards relevant to this PR.
Confirmation