Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #1891

Merged
merged 502 commits into from
Mar 4, 2025
Merged
Changes from 1 commit
Commits
Show all changes
502 commits
Select commit Hold shift + click to select a range
035d24e
Update rl.py
danielhanchen Feb 11, 2025
b67327b
Patching
danielhanchen Feb 11, 2025
56bf7a1
Update rl.py
danielhanchen Feb 11, 2025
8c23657
Update rl.py
danielhanchen Feb 11, 2025
e735ab5
Update rl.py
danielhanchen Feb 12, 2025
484afd7
Update rl.py
danielhanchen Feb 12, 2025
4a23920
Update rl.py
danielhanchen Feb 12, 2025
19b16bb
NEFTune
danielhanchen Feb 12, 2025
7e19c0f
Update rl.py
danielhanchen Feb 12, 2025
0ac3d15
Update rl.py
danielhanchen Feb 12, 2025
70b341c
Update rl.py
danielhanchen Feb 12, 2025
3b641de
Update rl.py
danielhanchen Feb 12, 2025
30ad4c4
Update rl.py
danielhanchen Feb 12, 2025
a848c01
Update rl.py
danielhanchen Feb 12, 2025
f25abe6
Update rl.py
danielhanchen Feb 12, 2025
0694463
Extra replacements
danielhanchen Feb 12, 2025
8cc0338
Update rl_replacements.py
danielhanchen Feb 12, 2025
a145a83
Update rl.py
danielhanchen Feb 12, 2025
39fbcfb
extra RL replacements
danielhanchen Feb 12, 2025
2e68bb3
Update rl_replacements.py
danielhanchen Feb 12, 2025
82d3f6a
Update rl_replacements.py
danielhanchen Feb 12, 2025
0c691cf
Update rl_replacements.py
danielhanchen Feb 12, 2025
cd6f9b6
Update rl_replacements.py
danielhanchen Feb 12, 2025
be568b0
Update rl_replacements.py
danielhanchen Feb 12, 2025
94e8298
Merge branch 'main' into nightly
danielhanchen Feb 12, 2025
9ade782
Update rl_replacements.py
danielhanchen Feb 12, 2025
e498150
Update llama.py
danielhanchen Feb 12, 2025
2a5aa3d
Update rl_replacements.py
danielhanchen Feb 12, 2025
2524538
Update _utils.py
danielhanchen Feb 12, 2025
c9ba000
Update loader_utils.py
danielhanchen Feb 12, 2025
5b2fd72
Update rl.py
danielhanchen Feb 12, 2025
3466186
Update rl_replacements.py
danielhanchen Feb 12, 2025
5dc8847
Update rl_replacements.py
danielhanchen Feb 12, 2025
9aad48e
Update rl.py
danielhanchen Feb 12, 2025
f121a5c
Update llama.py
danielhanchen Feb 12, 2025
5052d35
Update llama.py
danielhanchen Feb 12, 2025
a11aa96
Update llama.py
danielhanchen Feb 12, 2025
a6abe02
Update llama.py
danielhanchen Feb 12, 2025
d867faa
autocast
danielhanchen Feb 12, 2025
44c9228
Update rl_replacements.py
danielhanchen Feb 12, 2025
e83d854
Update llama.py
danielhanchen Feb 12, 2025
623eb65
Update rl_replacements.py
danielhanchen Feb 13, 2025
7e612f0
Update rl_replacements.py
danielhanchen Feb 13, 2025
a45266b
Update rl_replacements.py
danielhanchen Feb 13, 2025
c855d7e
Update rl_replacements.py
danielhanchen Feb 13, 2025
d7cefba
Update llama.py
danielhanchen Feb 13, 2025
52d996a
Update rl_replacements.py
danielhanchen Feb 13, 2025
56f5b31
Update llama.py
danielhanchen Feb 13, 2025
5f1e98c
Update llama.py
danielhanchen Feb 13, 2025
e713129
Update llama.py
danielhanchen Feb 13, 2025
310fc16
Update llama.py
danielhanchen Feb 13, 2025
76a122e
Update llama.py
danielhanchen Feb 13, 2025
2dd29e5
Update rl_replacements.py
danielhanchen Feb 13, 2025
3c5be91
Update llama.py
danielhanchen Feb 13, 2025
e548b15
Update llama.py
danielhanchen Feb 13, 2025
296b3b3
Update llama.py
danielhanchen Feb 13, 2025
8de588b
Update llama.py
danielhanchen Feb 13, 2025
f87909a
Update pyproject.toml
danielhanchen Feb 13, 2025
2704440
Update llama.py
danielhanchen Feb 13, 2025
42e1967
Update llama.py
danielhanchen Feb 13, 2025
36bf805
Update llama.py
danielhanchen Feb 13, 2025
a3af8e3
Update llama.py
danielhanchen Feb 13, 2025
9d10d2f
Update llama.py
danielhanchen Feb 13, 2025
b30a81f
Update llama.py
danielhanchen Feb 13, 2025
b7e8559
Update llama.py
danielhanchen Feb 13, 2025
4b201d9
Update rl_replacements.py
danielhanchen Feb 13, 2025
dc723bc
Update rl_replacements.py
danielhanchen Feb 13, 2025
0309949
Update rl_replacements.py
danielhanchen Feb 13, 2025
c409574
Update rl_replacements.py
danielhanchen Feb 13, 2025
8e5b09a
Update llama.py
danielhanchen Feb 13, 2025
6652f1d
Update rl_replacements.py
danielhanchen Feb 13, 2025
9215bbe
Update rl_replacements.py
danielhanchen Feb 13, 2025
4bff998
Update rl_replacements.py
danielhanchen Feb 13, 2025
c859030
Update rl_replacements.py
danielhanchen Feb 13, 2025
2daa8e3
Update rl_replacements.py
danielhanchen Feb 13, 2025
527a0c4
Update rl_replacements.py
danielhanchen Feb 13, 2025
087a5dc
Update rl_replacements.py
danielhanchen Feb 13, 2025
73210b3
Update rl_replacements.py
danielhanchen Feb 13, 2025
9934ac5
Merge branch 'main' into nightly
danielhanchen Feb 13, 2025
2635f2a
Update llama.py
danielhanchen Feb 13, 2025
69ab838
Update _utils.py
danielhanchen Feb 13, 2025
d5d7a06
Merge branch 'main' into nightly
danielhanchen Feb 13, 2025
c9e450f
Merge branch 'main' into nightly
danielhanchen Feb 13, 2025
44d00e8
Merge branch 'main' into nightly
danielhanchen Feb 13, 2025
447dfc4
Merge branch 'main' into nightly
danielhanchen Feb 13, 2025
acf98dc
Update llama.py
danielhanchen Feb 14, 2025
1399110
Update _utils.py
danielhanchen Feb 14, 2025
881105b
Update rl_replacements.py
danielhanchen Feb 14, 2025
cfdd3f1
Update rl.py
danielhanchen Feb 14, 2025
95b7df5
Update rl.py
danielhanchen Feb 14, 2025
17bfcf9
Update rl.py
danielhanchen Feb 14, 2025
61c219d
Update rl.py
danielhanchen Feb 14, 2025
9794dc2
Update rl.py
danielhanchen Feb 14, 2025
3687a6f
Update llama.py
danielhanchen Feb 14, 2025
c495bfa
Update llama.py
danielhanchen Feb 14, 2025
f9055a7
Update llama.py
danielhanchen Feb 14, 2025
945e3f9
Update llama.py
danielhanchen Feb 14, 2025
3d9fe12
Update rl_replacements.py
danielhanchen Feb 14, 2025
ed90785
Update llama.py
danielhanchen Feb 14, 2025
640bc88
Update llama.py
danielhanchen Feb 14, 2025
bb3bb2d
Update llama.py
danielhanchen Feb 14, 2025
9065938
Update llama.py
danielhanchen Feb 14, 2025
07b48f5
Merge branch 'main' into nightly
danielhanchen Feb 14, 2025
48c5e0d
GRPO optimized
danielhanchen Feb 14, 2025
3a1fb63
Update rl.py
danielhanchen Feb 14, 2025
19014b0
Update rl_replacements.py
danielhanchen Feb 14, 2025
0c17e79
Update rl_replacements.py
danielhanchen Feb 14, 2025
aee44e2
Update rl.py
danielhanchen Feb 14, 2025
953d957
Update rl.py
danielhanchen Feb 14, 2025
2a2b9f7
Update rl.py
danielhanchen Feb 14, 2025
fcb0f4a
Update rl.py
danielhanchen Feb 14, 2025
eabc365
Update rl_replacements.py
danielhanchen Feb 14, 2025
7408318
Update rl_replacements.py
danielhanchen Feb 14, 2025
f35eae3
Update rl_replacements.py
danielhanchen Feb 14, 2025
2b89dae
Selective Log softmax
danielhanchen Feb 14, 2025
45c8431
Fix GRPO bsz
danielhanchen Feb 14, 2025
644cedf
Update rl.py
danielhanchen Feb 14, 2025
4b765d7
Update rl_replacements.py
danielhanchen Feb 14, 2025
0a7c56d
Update rl_replacements.py
danielhanchen Feb 15, 2025
1b43e1d
Update rl_replacements.py
danielhanchen Feb 15, 2025
d588665
Update rl_replacements.py
danielhanchen Feb 15, 2025
54bd827
Fix TRL
danielhanchen Feb 15, 2025
c6d6e6b
Merge branch 'main' into nightly
danielhanchen Feb 15, 2025
fa560ce
Metrics GRPO
danielhanchen Feb 15, 2025
46462f1
Update rl_replacements.py
danielhanchen Feb 15, 2025
12c497a
Update rl_replacements.py
danielhanchen Feb 15, 2025
b8aca94
Merge branch 'main' into nightly
danielhanchen Feb 15, 2025
c14faee
No compile
danielhanchen Feb 16, 2025
1fcad32
Update rl.py
danielhanchen Feb 16, 2025
80be827
Remove docs
danielhanchen Feb 16, 2025
9254243
Update rl.py
danielhanchen Feb 16, 2025
09cb804
Update rl.py
danielhanchen Feb 16, 2025
86dabcf
Update rl.py
danielhanchen Feb 16, 2025
ba1c93e
Update rl.py
danielhanchen Feb 16, 2025
0d75afd
Update rl_replacements.py
danielhanchen Feb 16, 2025
1803658
Update rl.py
danielhanchen Feb 16, 2025
a856085
Update rl.py
danielhanchen Feb 16, 2025
eeac4f3
Update rl_replacements.py
danielhanchen Feb 16, 2025
6f1beb0
Update rl_replacements.py
danielhanchen Feb 16, 2025
222b1e7
llama-quantize on WINDOWS WSL error fix - edit save.py (gguf saving b…
everythingisc00l Feb 16, 2025
103cff4
Update rl_replacements.py
danielhanchen Feb 17, 2025
89a1d03
Update rl_replacements.py
danielhanchen Feb 17, 2025
c46b544
Update rl_replacements.py
danielhanchen Feb 17, 2025
ed84307
Update rl_replacements.py
danielhanchen Feb 17, 2025
93d3f16
Update rl_replacements.py
danielhanchen Feb 17, 2025
429ba6d
Update rl_replacements.py
danielhanchen Feb 17, 2025
1e42bad
Update rl_replacements.py
danielhanchen Feb 17, 2025
38a1885
Update rl_replacements.py
danielhanchen Feb 17, 2025
f0ee4f5
Update rl_replacements.py
danielhanchen Feb 17, 2025
b68dce6
Update rl_replacements.py
danielhanchen Feb 17, 2025
0827067
Update llama.py
danielhanchen Feb 17, 2025
204cd7a
Update rl_replacements.py
danielhanchen Feb 17, 2025
e141075
Update rl_replacements.py
danielhanchen Feb 17, 2025
a07a9e3
Update rl_replacements.py
danielhanchen Feb 17, 2025
cf2720d
Update llama.py
danielhanchen Feb 17, 2025
5c6f586
Update llama.py
danielhanchen Feb 18, 2025
2e07623
Update rl_replacements.py
danielhanchen Feb 18, 2025
8025cfe
Update rl_replacements.py
danielhanchen Feb 18, 2025
ba48495
Update rl_replacements.py
danielhanchen Feb 18, 2025
f0078de
Update rl.py
danielhanchen Feb 18, 2025
15e0140
Update rl.py
danielhanchen Feb 18, 2025
5f5cca4
Update rl_replacements.py
danielhanchen Feb 18, 2025
d80be70
Update rl.py
danielhanchen Feb 18, 2025
47a85eb
Update rl.py
danielhanchen Feb 18, 2025
f09478d
Update rl_replacements.py
danielhanchen Feb 18, 2025
97637c5
Update rl_replacements.py
danielhanchen Feb 18, 2025
58bd27f
Update rl_replacements.py
danielhanchen Feb 18, 2025
7c0c749
Update rl_replacements.py
danielhanchen Feb 18, 2025
97b55c1
Update rl_replacements.py
danielhanchen Feb 18, 2025
24c7a2f
Update rl_replacements.py
danielhanchen Feb 18, 2025
06b2cd3
unsloth_num_chunks
danielhanchen Feb 18, 2025
cbb16e3
Update rl.py
danielhanchen Feb 18, 2025
d16299b
Update rl_replacements.py
danielhanchen Feb 18, 2025
0c1a808
Update rl_replacements.py
danielhanchen Feb 18, 2025
6796801
Update rl_replacements.py
danielhanchen Feb 18, 2025
bd046ca
Update rl.py
danielhanchen Feb 18, 2025
ac2e814
Update rl.py
danielhanchen Feb 18, 2025
a88712f
Update rl.py
danielhanchen Feb 18, 2025
0daa328
Update rl.py
danielhanchen Feb 18, 2025
1afe3f2
Update rl.py
danielhanchen Feb 18, 2025
6732822
Update rl_replacements.py
danielhanchen Feb 18, 2025
5efe9f3
Update rl_replacements.py
danielhanchen Feb 18, 2025
15442d1
Update rl_replacements.py (#1754)
SethHWeidman Feb 19, 2025
91ab43d
Optional logits
danielhanchen Feb 19, 2025
a6a5f60
Update rl.py
danielhanchen Feb 19, 2025
83ce085
Update rl.py
danielhanchen Feb 19, 2025
8ece11f
Update rl.py
danielhanchen Feb 19, 2025
bc6bfae
Update rl.py
danielhanchen Feb 20, 2025
95fb6a4
Update rl.py
danielhanchen Feb 20, 2025
ba01cf5
Update rl.py
danielhanchen Feb 20, 2025
eb48b98
Update rl.py
danielhanchen Feb 20, 2025
3c750a1
Update rl.py
danielhanchen Feb 20, 2025
515cf5a
Update rl_replacements.py
danielhanchen Feb 20, 2025
2cf4349
Update rl.py
danielhanchen Feb 20, 2025
ae8bf68
Update rl.py
danielhanchen Feb 20, 2025
e07f4bc
Update rl.py
danielhanchen Feb 20, 2025
f11e5ab
Merge branch 'main' into nightly
danielhanchen Feb 20, 2025
3fccf5d
Update rl.py
danielhanchen Feb 20, 2025
798ad95
fix an import error (#1767)
NinoRisteski Feb 20, 2025
2957d89
SamplingParams
danielhanchen Feb 20, 2025
19d57bc
Convert mask to float (#1762)
Erland366 Feb 20, 2025
07aea40
[Windows Support] Add latest `xformers` wheels to pyproject.toml (#1753)
versipellis Feb 20, 2025
77109a4
Merge branch 'nightly' of https://github.com/unslothai/unsloth into n…
danielhanchen Feb 20, 2025
f3d9efb
vLLMSamplingParams
danielhanchen Feb 20, 2025
6d5caca
Update __init__.py
danielhanchen Feb 20, 2025
3a5610e
default num_chunks == -1
danielhanchen Feb 20, 2025
0362bd2
Versioning
danielhanchen Feb 20, 2025
2969db8
Merge branch 'main' into nightly
danielhanchen Feb 20, 2025
b5eda24
Update llama.py
danielhanchen Feb 20, 2025
7de0022
Update llama.py
danielhanchen Feb 20, 2025
d4d7694
Update llama.py
danielhanchen Feb 20, 2025
0bbfbe8
Update llama.py
danielhanchen Feb 20, 2025
ae6e2bd
Update llama.py
danielhanchen Feb 20, 2025
1792deb
Update _utils.py
danielhanchen Feb 20, 2025
5dcd079
Update rl_replacements.py
danielhanchen Feb 20, 2025
ec6e0b7
Update rl_replacements.py
danielhanchen Feb 20, 2025
bc1d2ce
Update pyproject.toml
danielhanchen Feb 20, 2025
adbe38e
Update pyproject.toml
danielhanchen Feb 20, 2025
a9b542f
Export Model to ollama.com (#1648)
gjyotin305 Feb 22, 2025
f853ac0
Merge branch 'main' into nightly
danielhanchen Mar 3, 2025
9cab347
Update cross_entropy_loss.py
danielhanchen Mar 3, 2025
0ae9082
torch_cuda_device
danielhanchen Mar 3, 2025
f21314c
Update utils.py
danielhanchen Mar 3, 2025
9215212
Update utils.py
danielhanchen Mar 3, 2025
9d95aee
Update utils.py
danielhanchen Mar 3, 2025
35e9144
device
danielhanchen Mar 3, 2025
30b6f94
device
danielhanchen Mar 3, 2025
64e2b00
Update loader.py
danielhanchen Mar 3, 2025
ffa3278
Update llama.py
danielhanchen Mar 3, 2025
748c5b5
Update README.md
danielhanchen Mar 3, 2025
469ed48
Update llama.py
danielhanchen Mar 3, 2025
bc87afd
Update llama.py
danielhanchen Mar 3, 2025
ee9d6e5
Update _utils.py
danielhanchen Mar 4, 2025
91458bb
Update utils.py
danielhanchen Mar 4, 2025
a7a5d75
Update utils.py
danielhanchen Mar 4, 2025
d93cca2
Update utils.py
danielhanchen Mar 4, 2025
6e2a3a8
Update utils.py
danielhanchen Mar 4, 2025
8f9ba99
Update utils.py
danielhanchen Mar 4, 2025
ed697da
Update llama.py
danielhanchen Mar 4, 2025
d73c34b
Update llama.py
danielhanchen Mar 4, 2025
4485da7
Update llama.py
danielhanchen Mar 4, 2025
45ea48c
Update llama.py
danielhanchen Mar 4, 2025
8c4b79c
Update llama.py
danielhanchen Mar 4, 2025
c2ae510
Update utils.py
danielhanchen Mar 4, 2025
432ea24
Update utils.py
danielhanchen Mar 4, 2025
dcff03c
Update utils.py
danielhanchen Mar 4, 2025
6ef0866
Update utils.py
danielhanchen Mar 4, 2025
8c8ce96
__version__
danielhanchen Mar 4, 2025
208971b
Update rl.py
danielhanchen Mar 4, 2025
adc6977
Bug fixes
danielhanchen Mar 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update rl.py
  • Loading branch information
danielhanchen committed Feb 11, 2025
commit 8c236572134d1c4798339992d890363fbb56479e
22 changes: 11 additions & 11 deletions unsloth/models/rl.py
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,17 @@ def _patch_trl_rl_trainers(trainer_file = "grpo_trainer"):
extra_args += eval_changes
pass

# Check max_seq_length
if "max_seq_length" in call_args:
length_check = \
"if hasattr(model, 'max_seq_length') and model.max_seq_length > max_seq_length:\n"\
" print('Unsloth: You set `max_seq_length` as ' + str(max_seq_length) + ' but the\\n'\n"\
" 'model maximum sequence length is ' + str(model.max_seq_length) + '. We will reduce it.')\n"
" max_seq_length = model.max_seq_length\n"
"if hasattr(model, 'max_seq_length') and max_seq_length is None: max_seq_length = model.max_seq_length\n"
extra_args += length_check
pass

# Add statistics as well!
extra_args += \
"from unsloth_zoo.logging_utils import PatchRLStatistics\n"\
Expand Down Expand Up @@ -298,17 +309,6 @@ def _patch_trl_rl_trainers(trainer_file = "grpo_trainer"):
extra_args += num_proc_check
pass

# Check max_seq_length
if "max_seq_length" in call_args:
length_check = \
"if hasattr(model, 'max_seq_length') and model.max_seq_length > max_seq_length:\n"\
" print('Unsloth: You set `max_seq_length` as ' + str(max_seq_length) + ' but the\\n'\n"\
" 'model maximum sequence length is ' + str(model.max_seq_length) + '. We will reduce it.')\n"
" max_seq_length = model.max_seq_length\n"
"if hasattr(model, 'max_seq_length') and max_seq_length is None: max_seq_length = model.max_seq_length\n"
extra_args += length_check
pass

# Create RLConfig args
extra_args = extra_args.split("\n")
extra_args = "\n".join(" "*8 + x for x in extra_args)
Expand Down