-
-
Notifications
You must be signed in to change notification settings - Fork 17
Taskbar fix + general icon stuff #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: windows-support
Are you sure you want to change the base?
Conversation
|
(oops, forgot to do the actual code) |
Thickening the white arc thing makes it render properly without looking odd
- Skip files that aren't shortcuts immediately, without waiting for it to error - Change the very verbose logs to be trace level - Logs loaded shortcuts (as trace)
this makes icons render *much* nicer, since it's a power of two (and the recommended sizes for them are *also* powers of two)
why would you want to do that
They'll probably never be used, but why not keep them
|
what is going on here... |
The changes to all the other files aren't really major The relevant SO answer for the WIN32 stuff is https://stackoverflow.com/a/78190249/28673940, and the main modifications are really just to structure and making it output an iced image handle. |
|
This isn't really ready for merging yet, since I don't think I tested it it enough (and I haven't really checked the soundness of the WIN32 stuff, but it's probably fine) |
Otherwise, the function returns before the objects get deleted (leak!)
Makes it so that it doesn't make an iced image handle for anything *except* the returned icon. This used to happen because it returned from a function that converted *all* of them to iced image handles, even though only the first was considered.
Changes
PathBufinstead ofString(also technically unrelated)